On Thu, Nov 21, 2019 at 3:35 PM Ilya Maximets <i.maxim...@ovn.org> wrote: > > On 21.11.2019 14:58, Ilya Maximets wrote: > > 'ol_flags' of DPDK mbuf could contain bits responsible for external > > or indirect buffers which are not actually offload flags in a common > > sense. Clearing/copying of these flags could lead to memory leaks of > > external memory chunks and crashes due to access to wrong memory. > > > > OVS should not clear these flags while resetting offloads and also > > should not copy them to the newly allocated packets. > > > > This change is required to support DPDK 19.11, as some drivers may > > return mbufs with these flags set. However, it might be good to do > > the same for DPDK 18.11, because these flags are present and should > > be taken into account. > > > > Signed-off-by: Ilya Maximets <i.maxim...@ovn.org>
As discussed during the OVS-DPDK public meeting earlier, I am ok with your suggestion of going with this patch as a first step. We will have to keep an eye on new flags on the dpdk side. Then once the dpdk ring ports have been dropped, we can revisit this. Reviewed-by: David Marchand <david.march...@redhat.com> > We could also add the following tag: > Fixes: 03f3f9c0faf8 ("dpdk: Update to use DPDK 18.11.") Yes. Thanks. -- David Marchand _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev