On 12/19/2019 1:11 AM, Ilya Maximets wrote: > I really roughly looked through the series and made a couple of comments. > Also, there are few checkpatch warnings about line lengths. And it's > still unclear what is the profit from dynamic allocation of flow patters > (I didn't decide if I like or dislike this change).
Actions are dynamically allocated, allowing just passing "struct flow_actions *actions" to various functions, without propagating a struct with all the actions, and also allows incrementally adding more actions without changing such struct. With patterns, I'd like to keep it, so it is more aligned with actions dynamic allocation, with the same benefits, though such propagating can be currently only to one function. The next series on top of this one I will submit is VXLAN offloading, which will introduce more functions of patterns, enjoying the same benefits. > > One more thing I want to mention is that we're likely going to have > explicit drop actions with this patch: > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.ozlabs.org%2Fpatch%2F1211955%2F&data=02%7C01%7Celibr%40mellanox.com%7C34c5e23e65124344bceb08d7840f9474%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C637123074772939197&sdata=Mmm%2BJY9TKjVabSWjowvXqeei76JmtP%2BaH3x2%2B2eCaVE%3D&reserved=0 > It's unclear right now which patches will be applied first, but anyway > netdev-offload-dpdk will need to support this OVS_ACTION_ATTR_DROP > somehow. Should be easy to support if we'll ignore the drop reason. > Statistics update might be harder and, I think, not necessary right now. > Just noticing for you to keep in mind/prepare for the change. Thanks. OK. I noticed that this patch doesn't change netdev-offload-tc.c. Don't you think this patch should be changed to use this new attribute there too? > > BTW, I'm traveling starting from tomorrow (today already) until the end > of next week, so I'll most likely not be able to review for that period. > However, should still be reachable, but slower in replies. bon voyage > > Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
