On 04/02/2020 21:28, David Marchand wrote:
> The check on TSO capability did not ensure ip checksum, tcp checksum and
> TSO tx offloads were available which resulted in a port init failure
> (example below with a ena device):
>
> *2020-02-04T17:42:52.976Z|00084|dpdk|ERR|Ethdev port_id=0 requested Tx
> offloads 0x2a doesn't match Tx offloads capabilities 0xe in
> rte_eth_dev_configure()*
>
> Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support")
>
> Reported-by: Ravi Kerur <rke...@gmail.com>
> Signed-off-by: David Marchand <david.march...@redhat.com>
> ---
> lib/netdev-dpdk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
> index b108cbd6b..eb1a7af94 100644
> --- a/lib/netdev-dpdk.c
> +++ b/lib/netdev-dpdk.c
> @@ -1132,7 +1132,7 @@ dpdk_eth_dev_init(struct netdev_dpdk *dev)
> dev->hw_ol_features &= ~NETDEV_RX_HW_SCATTER;
> }
>
> - if (info.tx_offload_capa & tx_tso_offload_capa) {
> + if ((info.tx_offload_capa & tx_tso_offload_capa) == tx_tso_offload_capa)
> {
> dev->hw_ol_features |= NETDEV_TX_TSO_OFFLOAD;
> } else {
> dev->hw_ol_features &= ~NETDEV_TX_TSO_OFFLOAD;
>
Acked-by: Kevin Traynor <ktray...@redhat.com>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
