Thanks Illya for pointing out this, I checked if_packet.h in git.kernel.org by 
using v3.10 tag, it indeed can support TPACKET_V3

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/if_packet.h?h=v3.10

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/if_packet.h?h=v3.10#n225

#define TPACKET3_HDRLEN         (TPACKET_ALIGN(sizeof(struct tpacket3_hdr)) + 
sizeof(struct sockaddr_ll))

So we can safely support TPACKET_V3 only because ovs' minimal kernel 
requirement is 3.10.0

-----邮件原件-----
发件人: Ilya Maximets [mailto:i.maxim...@ovn.org] 
发送时间: 2020年2月6日 19:11
收件人: ovs-dev@openvswitch.org; Yi Yang (杨燚)-云服务集团 <yangy...@inspur.com>; William 
Tu <u9012...@gmail.com>
抄送: Ben Pfaff <b...@ovn.org>; Ilya Maximets <i.maxim...@ovn.org>
主题: Re: [ovs-dev] [PATCH] Use TPACKET_V1/V2/V3 to accelerate veth for DPDK 
datapath

> On Sun, Feb 2, 2020 at 8:06 PM Yi Yang (杨燚)-云服务集团 <yangyi01 at inspur.com> 
> wrote:
>>
>> Hi, William
>>
>> Sorry for last reply, I don't know why I always can't get your 
>> comments email from my outlook, Ben's comments are ok, I also can't 
>> see your comments in outlook junk box.
>>
>> About your comments in
>> https://mail.openvswitch.org/pipermail/ovs-dev/2020-January/367146.ht
>> ml, I checked it in my CentOS 7 which has 3.10.0 kernel, TPACKET_V3 
>> sample code can work, so I'm ok to remove V1&V2 code.
>>
> 
> OK thank you for confirming that v3 works on 3.10 cento 7!


FYI, rhel/centos 3.10 kernels has almost nothing in common with upstream 3.10 
kernel.

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to