On Thu, Feb 06, 2020 at 05:17:33PM +0800, Tao YunXiang wrote: > Commit a529e3cd1f (ovsdb-server: Allow OVSDB clients to specify the > UUID for inserted rows) solves ovsdb-client specifing the UUID for > insert operation. OVSDB now can support directly using uuid to identify > a row. But for xxxctl tool,specifying uuid when creating a row is not > yet supported . This patch tried to specify uuid when creating a row > by the ctl tools. A new parameter --row_uuid is added to setup row's UUID. > e.g. ovn-nbctl --row_uuid=3da0398b-a5a8-4bc9-808d-fa662865138f create > logical_switch name='abc' > > Co-authored-by: Liu Chang <[email protected]> > Co-authored-by: Rong Yin <[email protected]> > Signed-off-by: Tao YunXiang <[email protected]> > Signed-off-by: Liu Chang <[email protected]> > Signed-off-by: Rong Yin <[email protected]> > > CC: Han Zhou <[email protected]>
Thanks for working on this. This warrants an item in NEWS and documentation for the new feature. I don't think ovsdb_data_row_uuid() is a very useful function. I would drop it. ovsdb_idl_txn_commit() can be simplified if uuids are specified, because it's no longer necessary to specify named-uuids or to call substitute_uuids(). _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
