Bleep bloop. Greetings Timothy Redaelli, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 121 characters long (recommended limit is 79)
#36 FILE: utilities/ovn-ctl:95:
ovn-appctl -t $OVN_RUNDIR/$ctl_file
ovsdb-server/set-active-ovsdb-server-probe-interval $inactive_probe_to_active
WARNING: Line is 142 characters long (recommended limit is 79)
#77 FILE: utilities/ovn-ctl:932:
--db-nb-probe-interval-to-active Active probe interval from standby to active
ovsdb-server remote (default: $DB_NB_PROBE_INTERVAL_TO_ACTIVE)
WARNING: Line is 142 characters long (recommended limit is 79)
#82 FILE: utilities/ovn-ctl:937:
--db-sb-probe-interval-to-active Active probe interval from standby to active
ovsdb-server remote (default: $DB_SB_PROBE_INTERVAL_TO_ACTIVE)
WARNING: Line is 88 characters long (recommended limit is 79)
#95 FILE: utilities/ovn-ctl.8.xml:154:
<p><code>--db-nb-probe-interval-to-active=<var>Time in
milliseconds</var></code></p>
WARNING: Line is 88 characters long (recommended limit is 79)
#96 FILE: utilities/ovn-ctl.8.xml:155:
<p><code>--db-sb-probe-interval-to-active=<var>Time in
milliseconds</var></code></p>
WARNING: Line is 144 characters long (recommended limit is 79)
#107 FILE: utilities/ovn-ctl.8.xml:248:
<p><code># ovn-ctl --db-nb-sync-from-addr=x.x.x.x
--db-nb-sync-from-port=6641 --db-nb-probe-interval-to-active=60000
demote_ovnnb</code></p>
WARNING: Line is 144 characters long (recommended limit is 79)
#108 FILE: utilities/ovn-ctl.8.xml:249:
<p><code># ovn-ctl --db-sb-sync-from-addr=x.x.x.x
--db-sb-sync-from-port=6642 --db-sb-probe-interval-to-active=60000
demote_ovnsb</code></p>
WARNING: Line is 109 characters long (recommended limit is 79)
#128 FILE: utilities/ovndb-servers.ocf:31:
INACTIVE_PROBE_TO_MASTER=${OCF_RESKEY_inactive_probe_interval_to_master:-${INACTIVE_PROBE_TO_MASTER_DEFAULT}}
WARNING: Line is 92 characters long (recommended limit is 79)
#154 FILE: utilities/ovndb-servers.ocf:281:
--db-nb-probe-interval-to-active=${INACTIVE_PROBE_TO_MASTER}
WARNING: Line is 92 characters long (recommended limit is 79)
#159 FILE: utilities/ovndb-servers.ocf:285:
--db-sb-probe-interval-to-active=${INACTIVE_PROBE_TO_MASTER}
WARNING: Line is 92 characters long (recommended limit is 79)
#169 FILE: utilities/ovndb-servers.ocf:613:
--db-nb-probe-interval-to-active=${INACTIVE_PROBE_TO_MASTER}
WARNING: Line is 92 characters long (recommended limit is 79)
#174 FILE: utilities/ovndb-servers.ocf:617:
--db-sb-probe-interval-to-active=${INACTIVE_PROBE_TO_MASTER}
Lines checked: 180, Warnings: 12, Errors: 0
Please check this out. If you feel there has been an error, please email
acon...@redhat.com
Thanks,
0-day Robot
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
