Bleep bloop. Greetings Anton Ivanov, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line has trailing whitespace
#50 FILE: include/openvswitch/poll-loop.h:54:
* containing the events passed by the OS in .revents.
WARNING: Line is 86 characters long (recommended limit is 79)
#54 FILE: include/openvswitch/poll-loop.h:58:
bool poll_fd_register_at(int fd, int events, struct pollfd **hint, const char
*where);
WARNING: Line is 100 characters long (recommended limit is 79)
#55 FILE: include/openvswitch/poll-loop.h:59:
#define poll_fd_register(fd, events, hint) poll_fd_register_at(fd, events,
hint, OVS_SOURCE_LOCATOR)
WARNING: Line is 96 characters long (recommended limit is 79)
#77 FILE: include/openvswitch/poll-loop.h:87:
#define private_poll_fd_wait(fd, events) private_poll_fd_wait_at(fd, events,
OVS_SOURCE_LOCATOR)
WARNING: Line is 83 characters long (recommended limit is 79)
#102 FILE: lib/poll-loop.c:46:
bool valid; /* Marked invalid if we got a HUP/NVAL from
poll */
WARNING: Line is 82 characters long (recommended limit is 79)
#149 FILE: lib/poll-loop.c:166:
poll_fd_register_at(int fd, int events, struct pollfd **hint, const char
*where) {
WARNING: Line has trailing whitespace
#158 FILE: lib/poll-loop.c:175:
}
WARNING: Line is 101 characters long (recommended limit is 79)
#262 FILE: lib/poll-loop.c:492:
VLOG_FATAL("poll: persistence state corrupted, no hash entry
for %d", pollfds[i].fd);
WARNING: Line is 91 characters long (recommended limit is 79)
#273 FILE: lib/poll-loop.c:503:
* Note - "private" fds always want POLLIN - that emulates EPOLL,
/dev/poll, etc
WARNING: Line is 87 characters long (recommended limit is 79)
#274 FILE: lib/poll-loop.c:504:
* behaviour which they should be using in real life instead of
using poll()
WARNING: Line is 85 characters long (recommended limit is 79)
#277 FILE: lib/poll-loop.c:507:
/* update "occured" events for use by streams and handlers. In case
there
WARNING: Line is 83 characters long (recommended limit is 79)
#278 FILE: lib/poll-loop.c:508:
* is an existing (but not consumed yet) event, we OR the events in
the
WARNING: Line is 85 characters long (recommended limit is 79)
#279 FILE: lib/poll-loop.c:509:
* stored record with the new ones - it is the job of the stream to
clear
WARNING: Line is 93 characters long (recommended limit is 79)
#366 FILE: lib/stream-fd.c:114:
/* poll-loop is providing us with hints for IO. If we got a HUP/NVAL we
skip straight
WARNING: Line is 89 characters long (recommended limit is 79)
#367 FILE: lib/stream-fd.c:115:
* to the read which should return 0 if the HUP is a real one, if not
we clear it
WARNING: Line is 87 characters long (recommended limit is 79)
#370 FILE: lib/stream-fd.c:118:
if ((!(stream->hint->revents & (POLLHUP | POLLNVAL))) &&
(!stream->rx_ready)) {
WARNING: Line is 93 characters long (recommended limit is 79)
#527 FILE: lib/stream-ssl.c:706:
/* poll-loop is providing us with hints for IO. If we got a HUP/NVAL we
skip straight
WARNING: Line is 89 characters long (recommended limit is 79)
#528 FILE: lib/stream-ssl.c:707:
* to the read which should return 0 if the HUP is a real one, if not
we clear it
WARNING: Line is 98 characters long (recommended limit is 79)
#531 FILE: lib/stream-ssl.c:710:
if ((!(stream->hint->revents & (POLLHUP | POLLNVAL))) && (sslv->rx_want
== SSL_READING)) {
WARNING: Line has trailing whitespace
#535 FILE: lib/stream-ssl.c:714:
/* POLLIN event from poll loop, mark us as ready
WARNING: Line is 83 characters long (recommended limit is 79)
#626 FILE: lib/stream-ssl.c:889:
private_poll_fd_wait(sslv->fd,
want_to_poll_events(sslv->rx_want));
Lines checked: 729, Warnings: 21, Errors: 0
Please check this out. If you feel there has been an error, please email
acon...@redhat.com
Thanks,
0-day Robot
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
