On Tue, Mar 24, 2020 at 03:38:31PM +0100, Ilya Maximets wrote: > On 3/24/20 3:27 PM, Ilya Maximets wrote: > > On 3/24/20 3:17 PM, William Tu wrote: > >> Due to not acquiring lock, clang reports: > >> lib/vlog.c:618:12: error: reading variable 'log_fd' requires holding > >> mutex > >> 'log_file_mutex' [-Werror,-Wthread-safety-analysis] > >> return log_fd; > >> > >> The patch fixes it by creating a function in vlog.c to write > >> directly to log file unsafely. > >> > >> Tested-at: > >> https://travis-ci.org/github/williamtu/ovs-travis/builds/666165883 > >> Fixes: ecd4a8fcdff2 ("fatal-signal: Log backtrace when no monitor daemon.") > >> Suggested-by: Ilya Maximets <i.maxim...@ovn.org> > >> Signed-off-by: William Tu <u9012...@gmail.com> > >> --- > > I didn't test, but the code looks good to me. > > Acked-by: Ilya Maximets <i.maxim...@ovn.org> Thanks, applied to master. William
_______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
