On Wed, Apr 29, 2020 at 11:07 AM William Tu <u9012...@gmail.com> wrote: > > On Tue, Apr 28, 2020 at 03:29:10AM +0000, 姜立东 wrote: > > Hi William, > > > > > - /* Use kernel netdev's packet and byte counts since vport's > > > counters > > > - * do not reflect packet counts on the wire when GSO, TSO or GRO > > > are > > > - * enabled. */ > > > > Actually I think it should be moved to netdev_stats_from_ovs_vport_stats > > :), that explains what netdev_stats_from_ovs_vport_stats is doing. > > In fact, I think better solution is copying all physical abnormal counters > > in netdev_stats_from_ovs_vport_stats , > > and remove this copy from netdev_linux_get_stats. > > but netdev_stats_from_ovs_vport_stats is in kernel module that may not be > > upgraded in some application scenarios. > > So I moved to remove unnecessary copies, such as RX/TX bytes, packets, > > drops. > > > > Regards, > > Lidong > > oh, I see your point. Then this looks good to me. > Add Pravin to see if he has some comments. >
The patch looks fine to me. Thanks, Pravin. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
