On 2020-05-07 6:54 PM, Aaron Conole wrote:
> It's possible that port ordering could cause the block ID to change
> after enabling / detecting TC Flower support. Therefore, fetch the
> block_id again after probing.
Maybe be more specific and add that block ID could change after probe
for block support, instead of general tc flower support.
beside that looks good to me.
Acked-by: Roi Dayan <r...@mellanox.com>
>
> Fixes: edc2055a2bf7 ("netdev-offload-tc: Flush rules on ingress block when
> init tc flow api")
> Cc: Dmytro Linkin <dmitro...@mellanox.com>
> Co-authored-by: Marcelo Leitner <mleit...@redhat.com>
> Signed-off-by: Marcelo Leitner <mleit...@redhat.com>
> Signed-off-by: Aaron Conole <acon...@redhat.com>
> ---
> lib/netdev-offload-tc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/netdev-offload-tc.c b/lib/netdev-offload-tc.c
> index 875ebef719..8864555d01 100644
> --- a/lib/netdev-offload-tc.c
> +++ b/lib/netdev-offload-tc.c
> @@ -1939,6 +1939,7 @@ netdev_tc_init_flow_api(struct netdev *netdev)
> ovsthread_once_done(&multi_mask_once);
> }
>
> + block_id = get_block_id_from_netdev(netdev);
> error = tc_add_del_qdisc(ifindex, true, block_id, hook);
>
> if (error && error != EEXIST) {
>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
