On 09 Jun, Numan Siddique wrote: > On Sat, Jun 6, 2020 at 4:54 PM Gabriele Cerami <gcer...@redhat.com> wrote: > > > Replies to router solicitation follow a different flow than periodic RA. > > This flow currently does not honour the router_preference configuration. > > > > This patch modifies the flow to honour the flag, and send > > router preference indications in the reply RA following RFC4191 > > specifications > > > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1804576 > > Signed-off-by: Gabriele Cerami <gcer...@redhat.com> > > > > Hi Gabriele, > > Thank for the fix. > > The patch LGTM. However the compilation fails with the below error when > configured with "--enable-sparse --enable-Werror"
I think even just -Wshadow is sufficient, and maybe I have to refresh variable scopes. The redeclaration inside the case statement doesn't seem to shadow the one on the function caller, but it does on the function itself. Anyway, I don't think we need all these redeclarations inside the case statements, so I'm working on a patch that makes encode_PUT_ND_RA_OPTS pass ra directly instead of passing ofpacts and the ra_offset, encode_put_nd_ra_option can then just use the pointer. Problem is, the rest of the options assume mo_flags contains only addr_mode, so there's a bit more to rework to make everything pass again. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev