On Tue, Jun 16, 2020 at 10:13 AM Xidong Wang <wangxidong...@163.com> wrote: > > From: xidongwang <wangxidong...@163.com> > > The stack object “zone_limit” has 3 members. In function > ovs_ct_limit_get_default_limit(), the member "count" is > not initialized and sent out via “nla_put_nohdr”. > > Signed-off-by: xidongwang <wangxidong...@163.com> > --- > net/openvswitch/conntrack.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c > index 4340f25..1b7820a 100644 > --- a/net/openvswitch/conntrack.c > +++ b/net/openvswitch/conntrack.c > @@ -2020,6 +2020,7 @@ static int ovs_ct_limit_get_default_limit(struct > ovs_ct_limit_info *info, > { > struct ovs_zone_limit zone_limit; > int err; > + memset(&zone_limit, 0, sizeof(zone_limit)); why not init zone.count == 0, instead of memset, because zone_id/limit will be inited later. memset uses more cpu cycles. > zone_limit.zone_id = OVS_ZONE_LIMIT_DEFAULT_ZONE; > zone_limit.limit = info->default_limit; > -- > 2.7.4 > > _______________________________________________ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
-- Best regards, Tonghao _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev