On 18 Jun, Numan Siddique wrote: > On Sat, Jun 13, 2020 at 2:53 PM Gabriele Cerami <gcer...@redhat.com> wrote: > > > On 12 Jun, Gabriele Cerami wrote: > > > + /* RFC4191 section 2.2 */ > > > + if (ntohs(ra->router_lifetime) == 0) { > > > + ra->mo_flags &= IPV6_ND_RA_OPT_PRF_RESET_MASK; > > > + } > > > > Sorry for the spamming, not having test coverage for this part is > > proving challenging. I wonder if it's best to add an option for this too > > > > What do you mean by option ? You mean in the put_nd_ra_opts() ?
Yes, something similar to what I just added, since lifetime is part of the header too. If lifetime can be changed, I could add a test where I set it to 0 and verify that router_preference is forced to 0 too. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev