On Tue, Jul 7, 2020 at 8:03 PM Dumitru Ceara <dce...@redhat.com> wrote:
> On 7/7/20 3:16 PM, num...@ovn.org wrote:
> > From: Numan Siddique <num...@ovn.org>
> >
> > When load balancer(s) configured with VIPs are associated to a logical
> switch,
> > then ovn-northd adds the below logical flow so that the packets in the
> egress
> > switch pipeline enter the conntrack.
> >
> > table=0 (ls_out_pre_lb ), priority=100 , match=(ip),
> action=(reg0[[0]] = 1; next;)
> >
> > ovn-northd maintains a local boolean variable 'vip_configured' in
> > build_pre_lb() and adds the above lflow if this is true at the end.
> > But this variable is overriden as -> vip_configured = !!lb->n_vips;
> > when it loops through every load balancer associated with the logical
> switch.
> >
> > This is wrong and this patch fixes this issue.
> >
> > A test case is addd to test this scenario and the test case fails
> without the
> > fix in this patch.
> >
> > Fixes: bb9f2b9ce56c("ovn-northd: Consider load balancer active backends
> in router pipeline")
> >
> > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1849162
> > Reported-by: Tim Rozet <tro...@redhat.com>
> > Signed-off-by: Numan Siddique <num...@ovn.org>
>
> Nice catch! Looks good to me, thanks!
>
Thanks to Tim for catching this bug.
>
> Acked-by: Dumitru Ceara <dce...@redhat.com>
>
Thanks for the review. I applied this patch to master, branch-20.06 and
branch-20.03
Numan
> _______________________________________________
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
