Hi Han, Changes look fine.
Acked-by: Ankur Sharma <ankur.sha...@nutanix.com> Regards, Ankur ________________________________ From: dev <ovs-dev-boun...@openvswitch.org> on behalf of Han Zhou <hz...@ovn.org> Sent: Wednesday, July 29, 2020 6:44 PM To: d...@openvswitch.org <d...@openvswitch.org> Cc: Han Zhou <hz...@ovn.org> Subject: [ovs-dev] [PATCH ovn] expr.c: Fix argument type of expr_write_scope(). There is compile error introduced by the commit 2054d01247. *** ../lib/expr.c:3328:6: error: symbol 'expr_type_check' redeclared with different type (originally declared at ../include/ovn/expr.h:481) - incompatible argument 4 (different signedness) Makefile:1971: recipe for target 'lib/expr.lo' failed *** Fixes: 2054d01247 ("Add expression writeability scopes.") Signed-off-by: Han Zhou <hz...@ovn.org> --- lib/expr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/expr.c b/lib/expr.c index c07e7dd..6fb9675 100644 --- a/lib/expr.c +++ b/lib/expr.c @@ -3327,7 +3327,7 @@ expr_evaluate(const struct expr *e, const struct flow *uflow, * must free(). */ char * OVS_WARN_UNUSED_RESULT expr_type_check(const struct expr_field *f, int n_bits, bool rw, - uint32_t write_scope) + enum expr_write_scope write_scope) { if (n_bits != f->n_bits) { if (n_bits && f->n_bits) { -- 2.1.0 _______________________________________________ dev mailing list d...@openvswitch.org https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=s883GpUCOChKOHiocYtGcg&r=mZwX9gFQgeJHzTg-68aCJgsODyUEVsHGFOfL90J6MJY&m=6Hq4Iu6-qDZ2r4dRyx_Qw-HEpTmmqfEEJO5Chyck7Bs&s=8TfuSpbakHFWk34kNULN61Hyg4Z4qCeCA49VZ-T83E0&e= _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev