Bleep bloop. Greetings Alin Gabriel Serdean, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 115 characters long (recommended limit is 79)
#40 FILE: windows/ovs-windows-installer/Product.wxs:54:
<Feature Id="VC140Redistx86" Title="Visual C++ 14 Runtime x86"
AllowAdvertise="no" Display="hidden" Level="1"
WARNING: Line is 115 characters long (recommended limit is 79)
#45 FILE: windows/ovs-windows-installer/Product.wxs:58:
<Feature Id="VC140Redistx64" Title="Visual C++ 14 Runtime x64"
AllowAdvertise="no" Display="hidden" Level="1"
WARNING: Line is 88 characters long (recommended limit is 79)
#46 FILE: windows/ovs-windows-installer/Product.wxs:59:
Absent="disallow" InstallDefault="followParent"
TypicalDefault="install">
WARNING: Line is 107 characters long (recommended limit is 79)
#56 FILE: windows/ovs-windows-installer/Product.wxs:267:
<Merge Id="VC140Redistx86"
SourceFile="Redist\Microsoft_VC140_CRT_x86.msm" DiskId="1" Language="0" />
WARNING: Line is 107 characters long (recommended limit is 79)
#57 FILE: windows/ovs-windows-installer/Product.wxs:268:
<Merge Id="VC140Redistx64"
SourceFile="Redist\Microsoft_VC140_CRT_x64.msm" DiskId="1" Language="0" />
Lines checked: 63, Warnings: 5, Errors: 0
Please check this out. If you feel there has been an error, please email
acon...@redhat.com
Thanks,
0-day Robot
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
