On 9/21/20 9:01 AM, Han Zhou wrote: > > > On Thu, Sep 17, 2020 at 5:51 AM Dumitru Ceara <dce...@redhat.com > <mailto:dce...@redhat.com>> wrote: >> >> Avoid reparsing the *_force_snat_ip addresses for every logical router > port. >> These addresses are defined once for the whole router. >> > > The commit message is a little misleading. Originally it wasn't > reparsing for every logical router port. It was per-router. This patch > avoids one extra parsing. > > In addition, another minor comment is that the function name > "empty_lport_addresses" may be "lport_addresses_is_empty" to follow the > naming convention of a lot of xxx_is_empty() function names in OVN/OVS. > > With these addressed: > Acked-by: Han Zhou <hz...@ovn.org <mailto:hz...@ovn.org>> >
Thanks Han for the review! I'll address your comments and fix the issue Numan spotted and I'll respin this patch. Regards, Dumitru _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
