Bleep bloop.  Greetings Harry van Haaren, I am a robot and I have tried out 
your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 89 characters long (recommended limit is 79)
WARNING: Line lacks whitespace around operator
#111 FILE: lib/dpif-netdev-avx512.c:52:
    OVS_ALIGNED_VAR(CACHE_LINE_SIZE)struct netdev_flow_key 
keys_impl[NETDEV_MAX_BURST+1];

WARNING: Line is 87 characters long (recommended limit is 79)
#112 FILE: lib/dpif-netdev-avx512.c:53:
    OVS_ALIGNED_VAR(CACHE_LINE_SIZE)struct netdev_flow_key 
*key_ptrs[NETDEV_MAX_BURST];

WARNING: Line is 84 characters long (recommended limit is 79)
#113 FILE: lib/dpif-netdev-avx512.c:54:
    OVS_ALIGNED_VAR(CACHE_LINE_SIZE)struct pkt_flow_meta 
pkt_meta[NETDEV_MAX_BURST];

WARNING: Line is 86 characters long (recommended limit is 79)
WARNING: Line lacks whitespace around operator
#119 FILE: lib/dpif-netdev-avx512.c:60:
    struct netdev_flow_key *keys = (void *)(((char *)keys_impl) + 
(64-blocks_offset));

ERROR: C99 style comment
#163 FILE: lib/dpif-netdev-avx512.c:104:
               // TODO: remove this EMC hit from the dpcls lookup bitmask

WARNING: Line is 80 characters long (recommended limit is 79)
#177 FILE: lib/dpif-netdev-avx512.c:118:
    int any_miss = !dpcls_lookup(cls, (const struct netdev_flow_key **)key_ptrs,

WARNING: Line is 80 characters long (recommended limit is 79)
#189 FILE: lib/dpif-netdev-avx512.c:130:
    pmd_perf_update_counter(&pmd->perf_stats, PMD_STAT_MASKED_LOOKUP, wild_hit);

ERROR: Improper whitespace around control block
#202 FILE: lib/dpif-netdev-avx512.c:143:
        for(uint32_t j = 0; j < NETDEV_MAX_BURST; j += 8) {

ERROR: Improper whitespace around control block
#230 FILE: lib/dpif-netdev-avx512.c:171:
        for(int i = 0; i < action_batch.count; i++) {

ERROR: C99 style comment
#306 FILE: lib/dpif-netdev-private-dpif.h:27:
// TODO make this register/selectable just like DPCLS

ERROR: C99 style comment
#521 FILE: lib/dpif-netdev.c:8385:
    //memset(rules, 0, cnt * sizeof *rules);

Lines checked: 527, Warnings: 8, Errors: 5


Please check this out.  If you feel there has been an error, please email 
acon...@redhat.com

Thanks,
0-day Robot
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to