On Wed, Nov 4, 2020 at 3:44 AM Mark Michelson <mmich...@redhat.com> wrote:
>
> Aside from spelling "update" properly in the title of patch 1, this
> looks good to me.
>
> Acked-by: Mark Michelson
Thanks Dumitru for fixing this issue and thanks Mark for the reviews.
I applied this patch series to master by updating the typo in the
commit message of patch 1
and with the changes below in the patch 1.
****
diff --git a/controller/pinctrl.c b/controller/pinctrl.c
index 795b52fc3..a5236564b 100644
--- a/controller/pinctrl.c
+++ b/controller/pinctrl.c
@@ -189,7 +189,7 @@ static void run_put_mac_bindings(
struct ovsdb_idl_txn *ovnsb_idl_txn,
struct ovsdb_idl_index *sbrec_datapath_binding_by_key,
struct ovsdb_idl_index *sbrec_port_binding_by_key,
- struct ovsdb_idl_index *sbrec_mac_binding_by_lport_ip);
+ struct ovsdb_idl_index *sbrec_mac_binding_by_lport_ip)
OVS_REQUIRES(pinctrl_mutex);
static void wait_put_mac_bindings(struct ovsdb_idl_txn *ovnsb_idl_txn);
static void flush_put_mac_bindings(void);
@@ -3851,8 +3851,7 @@ mac_binding_add(struct ovsdb_idl_txn *ovnsb_idl_txn,
{
/* Convert ethernet argument to string form for database. */
char mac_string[ETH_ADDR_STRLEN + 1];
- snprintf(mac_string, sizeof mac_string,
- ETH_ADDR_FMT, ETH_ADDR_ARGS(ea));
+ snprintf(mac_string, sizeof mac_string, ETH_ADDR_FMT, ETH_ADDR_ARGS(ea));
const struct sbrec_mac_binding *b =
mac_binding_lookup(sbrec_mac_binding_by_lport_ip, logical_port, ip);
*****
Compilation with clang was failing in patch 1 with the below error message
****
../controller/pinctrl.c:193:5: error: declaration does not declare
anything [-Werror,-Wmissing-declarations]
OVS_REQUIRES(pinctrl_mutex);
^
/home/nusiddiq/workspace_cpp/openvswitch/ovs/include/openvswitch/compiler.h:126:5:
note: expanded from macro 'OVS_REQUIRES'
__attribute__((exclusive_locks_required(__VA_ARGS__)))
*****
Thanks.
@Dumitru Ceara I think this needs to be backported right ? If so, can
you please submit the patches to the branches.
The 2nd patch doesn't apply cleanly to the branch-20.09.
Thanks
Numan
>
> On 11/3/20 10:50 AM, Dumitru Ceara wrote:
> > This series aims at further restricting ARP/ND broadcast domain for self
> > originated packets. Until now those packets were always flooded on all
> > ports of the switch.
> >
> > The first patch of the series is needed in order to remove dependency on
> > self-originated GARPs to be sent through the network (OVS) between OVN
> > logical ports.
> >
> > Signed-off-by: Dumitru Ceara <dce...@redhat.com>
> >
> > Dumitru Ceara (2):
> > pinctrl: Directly udpate MAC_Bindings created by self originated
> > GARPs.
> > ovn-northd: Limit self originated ARP/ND broadcast domain.
> >
> >
> > controller/pinctrl.c | 108
> > ++++++++++++++++++++++++++++++++++++++---------
> > lib/mcast-group-index.h | 1
> > northd/ovn-northd.8.xml | 19 ++++----
> > northd/ovn-northd.c | 84 +++++++++++++++++++++++--------------
> > tests/ovn.at | 50 ++++++++++------------
> > 5 files changed, 173 insertions(+), 89 deletions(-)
> >
> > _______________________________________________
> > dev mailing list
> > d...@openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> >
>
> _______________________________________________
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
