On 11/3/2020 5:07 PM, Yi-Hung Wei wrote:
On Tue, Nov 3, 2020 at 4:06 PM Gregory Rose <gvrose8...@gmail.com> wrote:
On 11/3/2020 2:17 PM, Yi-Hung Wei wrote:
[snip]
Hi Greg,
I thought your change in datapath.c is to fix the following new added
lines in 9ba57fc7cccc ("datapath: Add hash info to upcall"). I found
it because the compilation goes fine before this patch on RHEL 7.7.
9ba57fc7cccc ("datapath: Add hash info to upcall")
@@ -523,6 +525,25 @@ static int queue_userspace_packet(struct datapath
*dp, struct sk_buff *skb,
.....
+#ifdef HAVE_L4_RXHASH
+ if (skb->l4_rxhash)
+#else
+ if (skb->l4_hash)
+#endif
+ hash |= OVS_PACKET_HASH_L4_BIT;
Hi Yi-Hung,
It was required when I removed this line:
-#if defined(HAVE_L4_RXHASH) && !defined(HAVE_RHEL_OVS_HOOK)
And then added the HAVE_L4_HASH. I guess it's six of one and
half a dozen of another. In any case, I have no objection to
using a Fixes tag with
9ba57fc7cccc ("datapath: Add hash info to upcall") in the
V3 patch. I'll use the other Fixes tag for the separated
cleanup patch.
[snip]
The new ABI is introduced in RHEL7.2, so the support that we will drop
is RHEL 7.0 and RHEL 7.1. Since RHEL 7.1 was introduced in 2015 March,
I think it is probably fine.
OK.
[snip]
By the way, what is your opinion on this?
https://mail.openvswitch.org/pipermail/ovs-dev/2020-October/376816.html
I think OOT kernel driver support still provides value IMO. For
example, Ubuntu 18.04 LTS uses 4.15 kernel by default, and the end of
life of 18.04 LTS is 2023. If we drop OOT kernel driver support, we
will make the 18.04 LTS users' life much harder.
The current OOT driver supports all the way up to 5.8. I don't see any
issue with deprecating it but still taking bug fixes if any come up.
But certainly the 4.15.x kernels for Ubuntu 18.04 LTS will all be
supported by the deprecated OOT driver in it's current state.
We can talk about it offline.
Thanks,
- Greg
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
