On Tue, Nov 17, 2020 at 05:50:20PM +0100, Dumitru Ceara wrote:
> It is not correct for ovn-controller to pass the current SB_Global.nb_cfg
> value to ofctrl_put() if there are pending changes to conditional
> monitoring clauses (local or in flight). It might be that after the
> monitor condition is acked by the SB, records that were added to the SB
> before SB_Global.nb_cfg was set are now sent as updates to
> ovn-controller. These should be first installed in OVS before
> ovn-controller reports that it caught up with the current
> SB_Global.nb_cfg value.
>
> Also, ofctrl_put should not advance cur_cfg if there are flow updates in
> flight.
>
> Fixes: ca278d98a4f5 ("ovn-controller: Initial use of incremental engine -
> quiet mode.")
> Signed-off-by: Dumitru Ceara <dce...@redhat.com>
>
> ---
> v2:
> - use new IDL *set_condition() return value.
> - fix ofctrl_put to not advance cur_cfg if there are flow updates in
> flight.
ovn-controller has changed (advanced?) to the point that I have trouble
understanding the code now. I'm going to assume that you understand it
pretty well, but please allow me to ask a question here. Will this
always manage to come up to date with some version of the sb, or is
there a chance that it never will report a consistent value if the sb
keeps changing quickly? I wasn't able to figure that out with a quick
look.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
