On 16 Dec 2020, at 13:04, Mark Gray wrote:
> Connections are added to IPsec using a connection name
> that is determined from the OVS port name and the tunnel
> type.
>
> GRE connections take the form:
> <iface>-<ver>
> Other connections take the form:
> <iface>-in-<ver>
> <iface>-out-<ver>
>
> The regex '|' operator parses strings left to right looking
> for the first match that it can find. '.*' is also greedy. This
> causes incorrect interface names to be parsed from active
> connections as other tunnel types are parsed as type
> GRE. This gives unexpected "is outdated" warnings and the
> connection is torn down.
>
> For example,
>
> 'ovn-424242-in-1' will produce an incorrect interface name of
> 'ovn-424242-in' instead of 'ovn-424242'.
>
> There are a number of ways this could be resolved including
> a cleverer regular expression, or re.findall(). However, this
> approach was taken as it simplifies the code easing maintainability.
>
> Signed-off-by: Mark Gray <mark.d.g...@redhat.com>
Reviewed and tested.
Acked-by: Eelco Chaudron <echau...@redhat.com>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
