On 1/7/21 8:06 PM, Ben Pfaff wrote:
> On Tue, Jan 05, 2021 at 09:57:46PM +0100, Ilya Maximets wrote:
>> On 12/22/20 1:21 AM, Ben Pfaff wrote:
>>> This follows up on commit 4241d652e465 ("jsonrpc: Avoid disconnecting
>>> prematurely due to long poll intervals."), which implemented the same
>>> thing in C.
>>>
>>> Requested-by: Ilya Maximets <[email protected]>
>>> Signed-off-by: Ben Pfaff <[email protected]>
>>> ---
>>> python/ovs/jsonrpc.py | 5 ++++-
>>> python/ovs/reconnect.py | 21 ++++++++++++++++++--
>>> tests/reconnect.at | 43 +++++++++++++++++++++++++++++++++++------
>>> tests/test-reconnect.c | 14 +++++++++++++-
>>> tests/test-reconnect.py | 13 ++++++++++++-
>>> 5 files changed, 85 insertions(+), 11 deletions(-)
>>>
>>
>> LGTM, Thanks!
>>
>> Acked-by: Ilya Maximets <[email protected]>
>
> Thank you. I applied this to master.
>
> I didn't backport to 2.13 or 2.14 because I'm not sure about the
> tradeoff between fixing theoretical problems in users of the Python
> implementation (which I haven't actually seen) versus the possibility of
> breaking something (either via Python changes or the test).
>
I agree that having this on master is enough.
Thanks.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev