On Mon, Jan 11, 2021 at 7:43 PM Ilya Maximets <[email protected]> wrote: > > On 5/23/20 12:33 PM, [email protected] wrote: > > From: Tonghao Zhang <[email protected]> > > > > When setting the meter rate to 4.3+Gbps, there is an overflow, the > > meters don't work as expected. > > > > Cc: Ilya Maximets <[email protected]> > > Cc: William Tu <[email protected]> > > Cc: Jarno Rajahalme <[email protected]> > > Cc: Ben Pfaff <[email protected]> > > Cc: Andy Zhou <[email protected]> > > Cc: Pravin Shelar <[email protected]> > > Acked-by: William Tu <[email protected]> > > Signed-off-by: Tonghao Zhang <[email protected]> > > --- > > include/openvswitch/ofp-meter.h | 2 +- > > lib/dpif-netdev.c | 4 ++-- > > lib/ofp-meter.c | 4 ++-- > > 3 files changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/include/openvswitch/ofp-meter.h > > b/include/openvswitch/ofp-meter.h > > index 6776eae87e26..f55f89ac1a71 100644 > > --- a/include/openvswitch/ofp-meter.h > > +++ b/include/openvswitch/ofp-meter.h > > @@ -37,7 +37,7 @@ struct ofputil_meter_band { > > uint16_t type; > > uint8_t prec_level; /* Non-zero if type == OFPMBT_DSCP_REMARK. > > */ > > uint32_t rate; > > - uint32_t burst_size; > > + uint64_t burst_size; > > This structure is part of a public API. We can't change it that simple. > > IIUC, the issue is on a datapath level, so it should be solvable without > modifying anything outside the datapath code. Good idea. Now the meter uses the burst_size of ofputil_meter_band to store the buckets of meters, it will overflow when we set the rate to 4294968. In my next version patch, I remove the "up" and introduce the "uint64_t burst_size", that may make the code clear, and fix that bug. More details, please see my patch, thanks. > Could you prepare this kind of fix and send it separately from the series? Yes, I sent with another path, which related to that patch, but patch 1 was not included. http://patchwork.ozlabs.org/project/openvswitch/patch/[email protected]/ http://patchwork.ozlabs.org/project/openvswitch/patch/[email protected]/ > Best regards, Ilya Maximets.
-- Best regards, Tonghao _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
