On 1/12/21 7:39 PM, Mark Michelson wrote: > By default, OVN and OVS errors and warnings are written to > stderr. GNU Autotest automatically fails a test if unexpected > data is written to stderr. This causes two problems: > 1) Unit tests that attempt off-nominal code paths may > fail because of a warning message in OVN or OVS. To get > around this, it is common for tests to pass "[ignore]" > to AT_CHECK's stderr parameter so that OVN/OVS log messages > do not cause failures. But... > 2) Passing "[ignore]" makes it so that unit tests cannot > then print their own messages to stderr to help debug > test failures. > > By disabling OVS/OVN log messages from going to the console, we allow > for tests to write their own messages to stderr. > > Signed-off-by: Mark Michelson <[email protected]> > ---
Looks good to me, thanks! Acked-by: Dumitru Ceara <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
