On Wed, Jan 13, 2021 at 9:32 AM 0-day Robot <ro...@bytheb.org> wrote:
> References: <1610507745-126223-2-git-send-email-svc.mail....@nutanix.com>
>
>
> Bleep bloop. Greetings Ankur Sharma, I am a robot and I have tried out
> your patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
>
>
> checkpatch:
> ERROR: Inappropriate spacing in pointer declaration
> WARNING: Line lacks whitespace around operator
> #127 FILE: northd/ovn-northd.c:1513:
> struct ovn_datapath_l3dgw_port* l3dgw_port =
> &(od->l3dgw_ports[iter]);
>
> ERROR: Inappropriate spacing in pointer declaration
> WARNING: Line lacks whitespace around operator
> #318 FILE: northd/ovn-northd.c:6277:
> struct ovn_datapath_l3dgw_port* l3dgw_port = &(od->l3dgw_ports[i]);
>
> WARNING: Line is 80 characters long (recommended limit is 79)
> #478 FILE: northd/ovn-northd.c:8781:
> * the router egress pipleine stage - S_ROUTER_OUT_UNDNAT if the
> logical
>
> ERROR: Inappropriate bracing around statement
> #657 FILE: northd/ovn-northd.c:10294:
> for (int iter = 0; iter < od->n_l3dgw_ports; iter++) {
>
> WARNING: Line is 82 characters long (recommended limit is 79)
> #880 FILE: northd/ovn-northd.c:11181:
> static struct vlog_rate_limit rl =
> VLOG_RATE_LIMIT_INIT(5, 1);
>
> Lines checked: 1883, Warnings: 4, Errors: 3
>
>
Hi Ankur,
Thanks for the patch. Compilation is failing with your patch applied -
https://github.com/ovsrobot/ovn/tree/series_224031
Thanks
Numan
>
> build:
> depbase=`echo lib/ovn-ic-sb-idl.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
> /bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99
> -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./ovn -I ./include -I
> ./lib -I ./lib -I
> /var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/OVSDIR/include
> -I
> /var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/OVSDIR/include
> -I
> /var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/OVSDIR/lib
> -I
> /var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/OVSDIR/lib
> -I
> /var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/OVSDIR
> -I
> /var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/OVSDIR
> -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith
> -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
> -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition
> -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing
> -Wshadow -Werror -Werror -g -O2 -MT lib/ovn-ic-sb-idl.lo -MD -MP -MF
> $depbase.Tpo -c -o lib/ovn-ic-sb-idl.lo lib/ovn-ic-sb-idl.c &&\
> mv -f $depbase.Tpo $depbase.Plo
> libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I
> ./include -I ./ovn -I ./include -I ./lib -I ./lib -I
> /var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/OVSDIR/include
> -I
> /var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/OVSDIR/include
> -I
> /var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/OVSDIR/lib
> -I
> /var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/OVSDIR/lib
> -I
> /var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/OVSDIR
> -I
> /var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/OVSDIR
> -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith
> -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
> -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition
> -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing
> -Wshadow -Werror -Werror -g -O2 -MT lib/ovn-ic-sb-idl.lo -MD -MP -MF
> lib/.deps/ovn-ic-sb-idl.Tpo -c lib/ovn-ic-sb-idl.c -o lib/ovn-ic-sb-idl.o
> /bin/sh ./libtool --tag=CC --mode=link gcc -std=gnu99
> -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith
> -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
> -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition
> -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing
> -Wshadow -Werror -Werror -g -O2 -release 20.12 -version-info 0:90
> -Wl,--version-script=./lib/libovn.sym -o lib/libovn.la -rpath
> /usr/local/lib lib/acl-log.lo lib/actions.lo lib/chassis-index.lo
> lib/expr.lo lib/extend-table.lo lib/ip-mcast-index.lo
> lib/mcast-group-index.lo lib/lex.lo lib/ovn-l7.lo lib/ovn-util.lo
> lib/logical-fields.lo lib/inc-proc-eng.lo lib/lb.lo lib/ovn-dirs.lo
> lib/ovn-nb-idl.lo lib/ovn-sb-idl.lo lib/ovn-ic-nb-idl.lo
> lib/ovn-ic-sb-idl.lo -lpthread -lrt -lm -lunbound
> libtool: link: ar cru lib/.libs/libovn.a lib/acl-log.o lib/actions.o
> lib/chassis-index.o lib/expr.o lib/extend-table.o lib/ip-mcast-index.o
> lib/mcast-group-index.o lib/lex.o lib/ovn-l7.o lib/ovn-util.o
> lib/logical-fields.o lib/inc-proc-eng.o lib/lb.o lib/ovn-dirs.o
> lib/ovn-nb-idl.o lib/ovn-sb-idl.o lib/ovn-ic-nb-idl.o lib/ovn-ic-sb-idl.o
> libtool: link: ranlib lib/.libs/libovn.a
> libtool: link: ( cd "lib/.libs" && rm -f "libovn.la" && ln -s "../
> libovn.la" "libovn.la" )
> depbase=`echo utilities/ovn-nbctl.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
> gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./ovn
> -I ./include -I ./lib -I ./lib -I
> /var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/OVSDIR/include
> -I
> /var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/OVSDIR/include
> -I
> /var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/OVSDIR/lib
> -I
> /var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/OVSDIR/lib
> -I
> /var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/OVSDIR
> -I
> /var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/OVSDIR
> -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith
> -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
> -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition
> -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing
> -Wshadow -Werror -Werror -g -O2 -MT utilities/ovn-nbctl.o -MD -MP -MF
> $depbase.Tpo -c -o utilities/ovn-nbctl.o utilities/ovn-nbctl.c &&\
> mv -f $depbase.Tpo $depbase.Po
> utilities/ovn-nbctl.c: In function ‘is_nat_rule_conflict’:
> utilities/ovn-nbctl.c:4213:34: error: unused parameter ‘logical_ip1’
> [-Werror=unused-parameter]
> const char *logical_ip1,
> ^
> utilities/ovn-nbctl.c:4214:34: error: unused parameter ‘logical_ip2’
> [-Werror=unused-parameter]
> const char *logical_ip2,
> ^
> utilities/ovn-nbctl.c:4215:27: error: unused parameter ‘is_v6’
> [-Werror=unused-parameter]
> bool is_v6)
> ^
> cc1: all warnings being treated as errors
> make[1]: *** [utilities/ovn-nbctl.o] Error 1
> make[1]: Leaving directory
> `/var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace'
> make: *** [all] Error 2
>
>
> Please check this out. If you feel there has been an error, please email
> acon...@redhat.com
>
> Thanks,
> 0-day Robot
> _______________________________________________
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
