On Tue, Feb 2, 2021 at 10:00 AM Ben Pfaff <b...@ovn.org> wrote: > > On Tue, Feb 02, 2021 at 05:11:09PM +0100, Ilya Maximets wrote: > > On 1/21/21 11:33 PM, Ben Pfaff wrote: > > > The calculation in tcp_reader_run() failed to account for L2 padding. > > > This fixes the problem, by moving the existing function > > > tcp_payload_length() from a conntrack private header file into > > > dp-packet.h and renaming it to suit the dp_packet style. > > > > > > Signed-off-by: Ben Pfaff <b...@ovn.org> > > > --- > > > > LGTM, > > Acked-by: Ilya Maximets <i.maxim...@ovn.org> > > Thanks, applied to master.
Hi Ben and Ilya, I'm confused with what l2_pad_size is. I thought it's between L2 and L3 header, there is a 2-byte padding to make it 16-byte alignment. But it doesn't look like that. Then every time dp_packet API use dp_packet_tail, we have to subtract the l2_pad_size. ex: dp_packet_l4_size() So is thie l2_pad_size the extra byte at the end of buffer? (before the memory pointed by dp_packet_tail(p)? Thanks William _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
