On 2/16/21 10:16 PM, Ben Pfaff wrote:
On Fri, Dec 11, 2020 at 03:43:22PM +0100, Dumitru Ceara wrote:
There are a few tests that fail (also northd-C tests) and I suspect it's
because the OVS IDL split patches [0] this commit depends on don't
include some of the recent fixes that went into the OVS IDL code, at
least the following:

I'm not sure whether the above comment was against an older form of the
idl-split patches that went into master, but to make sure I took a
careful look.

Yes, IIRC, back then the idl-split series that was under review didn't include the changes below.


- https://github.com/openvswitch/ovs/commit/97dbef6

I think that thiis is incorporated in the current OVS tree.  I see the
same code and comment in ovsdb-cs.c that was once in ovsdb-idl.c.

- https://github.com/openvswitch/ovs/commit/91a6a45
- https://github.com/openvswitch/ovs/commit/08e130a
- https://github.com/openvswitch/ovs/commit/f0d23f6

The above commits appear to me to be incorporated in the OVS tree
correctly.  Not much (any?) change was needed.  The idl-split didn't
have much effect on row tracking in general, because it's solidly on the
idl side of the split.


Now it's fine, thanks for double checking!

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to