On 1/27/21 12:03 PM, Ilya Maximets wrote: > On 1/27/21 11:42 AM, Dumitru Ceara wrote: >> On 1/22/21 8:04 PM, Ilya Maximets wrote: >>> This commit is based on a similar one from OVN by Dumitru Ceara: >>> a429b24f7bf5 ("ci: Enable AddressSanitizer in Linux clang CI test runs.") >>> >>> It's useful to run testsuite with address sanitizer enabled to catch >>> memory leaks and invalid memory accesses. Skipping re-check if >>> AddressSanitizer reports are present in the test run directory to >>> not lose them. >>> >>> Right now OVS has no memory leaks detected on a testsuite run with -O1. >>> With -O2 there are few false-positive leak reports in test-ovsdb >>> application, so not using this optimization level for now. For the >>> same reason not enabling leak detection by default for everyone. >>> Enabled only in CI. >>> >>> AddressSanitizer increases execution time for this job from ~12 to ~16 >>> minutes, but it looks like a reasonable sacrifice. >>> >>> Signed-off-by: Ilya Maximets <i.maxim...@ovn.org> >>> --- >> >> Looks good to me, thanks! >> >> Acked-by: Dumitru Ceara <dce...@redhat.com> >> > > Thanks, Dumitru. > > I'll defer applying of this patch for now. The 'bfd decay' test is unstable > while running under AddressSanitizer. It was always too time-sensitive. > We need to look at this test and fix it or disable for this CI job.
This test didn't fail for me for a last couple of weeks, so maybe the problem is not that frequent. Taking that into account, I think it's OK to apply this patch. Applied to master. Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev