From: Leonid Ryzhyk <lryz...@vmware.com> Export `ddlog_warn` and `ddlog_err` functions that are just wrappers around `VLOG_WARN` and `VLOG_ERR`. This is not ideal because the functions are exported by `ovn_util.c` and the resulting log messages use `ovn_util` as module name. More importantly, these functions do not do log rate limiting.
Signed-off-by: Leonid Ryzhyk <lryz...@vmware.com> Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Dumitru Ceara <dce...@redhat.com> --- TODO.rst | 6 ++++++ lib/ovn-util.c | 15 +++++++++++++++ lib/ovn-util.h | 5 +++++ 3 files changed, 26 insertions(+) diff --git a/TODO.rst b/TODO.rst index c15815539f4f..ecfe62870fb0 100644 --- a/TODO.rst +++ b/TODO.rst @@ -153,6 +153,12 @@ OVN To-do List hashtable lookup in parse_port_group() which can be avoided when we are sure that the Southbound DB uses the new format. +* ovn-northd-ddlog: Calls to warn() and err() from DDlog code would be + better refactored to use the Warning[] relation (and introduce an + Error[] relation once we want to issue some errors that way). This + would be easier with some improvements in DDlog to more easily + output to multiple relations from a single production. + * IP Multicast Relay * When connecting bridged logical switches (localnet) to logical routers diff --git a/lib/ovn-util.c b/lib/ovn-util.c index b6471063ef7e..a5e0ecd214b2 100644 --- a/lib/ovn-util.c +++ b/lib/ovn-util.c @@ -758,3 +758,18 @@ ovn_get_internal_version(void) sbrec_get_db_version(), N_OVNACTS, OVN_INTERNAL_MINOR_VER); } + +#ifdef DDLOG +/* Callbacks used by the ddlog northd code to print warnings and errors. */ +void +ddlog_warn(const char *msg) +{ + VLOG_WARN("%s", msg); +} + +void +ddlog_err(const char *msg) +{ + VLOG_ERR("%s", msg); +} +#endif diff --git a/lib/ovn-util.h b/lib/ovn-util.h index 08234611838a..55c7bf382a95 100644 --- a/lib/ovn-util.h +++ b/lib/ovn-util.h @@ -261,4 +261,9 @@ BUILD_ASSERT_DECL(SCTP_INIT_CHUNK_LEN == sizeof(struct sctp_init_chunk)); /* See RFC 4960 Sections 3.3.7 and 8.5.1 for information on this flag. */ #define SCTP_ABORT_CHUNK_FLAG_T (1 << 0) +#ifdef DDLOG +void ddlog_warn(const char *msg); +void ddlog_err(const char *msg); +#endif + #endif -- 2.28.0 _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev