Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch. Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #3723 FILE: northd/ovn-northd-ddlog.c:166: .cs = ovsdb_cs_create(database, 1 /* XXX */, &northd_cs_ops, ctx), WARNING: Comment with 'xxx' marker #4511 FILE: northd/ovn-northd-ddlog.c:954: * XXX If the transaction we're sending to the database fails, then WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around operator #4564 FILE: northd/ovn-northd-ddlog.c:1007: --ovnnb-db=DATABASE connect to ovn-nb database at DATABASE\n\ WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around operator #4566 FILE: northd/ovn-northd-ddlog.c:1009: --ovnsb-db=DATABASE connect to ovn-sb database at DATABASE\n\ WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around operator #4568 FILE: northd/ovn-northd-ddlog.c:1011: --unixctl=SOCKET override default control socket name\n\ WARNING: Line has trailing whitespace #6343 FILE: northd/ovn_northd.dl:176: var l3dgw_port = peer.and_then(|p| p.router.l3dgw_port), WARNING: Line has non-spaces leading whitespace WARNING: Line has trailing whitespace #9125 FILE: northd/ovn_northd.dl:2958: WARNING: Line has non-spaces leading whitespace WARNING: Line has trailing whitespace #12817 FILE: northd/ovn_northd.dl:6650: WARNING: Line has non-spaces leading whitespace WARNING: Line has trailing whitespace #13786 FILE: northd/ovn_northd.dl:7619: WARNING: Line has trailing whitespace #13987 FILE: northd/ovn_northd.dl:7820: } WARNING: Line has non-spaces leading whitespace WARNING: Line has trailing whitespace #13988 FILE: northd/ovn_northd.dl:7821: WARNING: Line has non-spaces leading whitespace WARNING: Line has trailing whitespace #13989 FILE: northd/ovn_northd.dl:7822: Lines checked: 14606, Warnings: 22, Errors: 0 build: -e 's,[@]pkgdatadir[@],/usr/local/share/ovn,g' \ -e 's,[@]sysconfdir[@],/usr/local/etc,g' \ -e 's,[@]bindir[@],/usr/local/bin,g' \ -e 's,[@]sbindir[@],/usr/local/sbin,g' \ -e 's,[@]abs_builddir[@],/var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace,g' \ -e 's,[@]abs_top_srcdir[@],/var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace,g' \ > utilities/ovn-lib.tmp mv utilities/ovn-lib.tmp utilities/ovn-lib :;{ \ echo '# Signature of the current package.' && \ echo 'm4_define([AT_PACKAGE_NAME], [ovn])' && \ echo 'm4_define([AT_PACKAGE_TARNAME], [ovn])' && \ echo 'm4_define([AT_PACKAGE_VERSION], [20.12.90])' && \ echo 'm4_define([AT_PACKAGE_STRING], [ovn 20.12.90])' && \ echo 'm4_define([AT_PACKAGE_BUGREPORT], [b...@openvswitch.org])'; \ } >'./package.m4' /bin/sh /var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/build-aux/missing autom4te --language=autotest -I '.' -o tests/testsuite.tmp tests/testsuite.at mv tests/testsuite.tmp tests/testsuite /bin/sh /var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/build-aux/missing autom4te --language=autotest -I '.' -o tests/system-kmod-testsuite.tmp tests/system-kmod-testsuite.at mv tests/system-kmod-testsuite.tmp tests/system-kmod-testsuite /bin/sh /var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/build-aux/missing autom4te --language=autotest -I '.' -o tests/system-userspace-testsuite.tmp tests/system-userspace-testsuite.at mv tests/system-userspace-testsuite.tmp tests/system-userspace-testsuite make[1]: *** No rule to make target `northd/OVN_Northbound.dl', needed by `all-am'. Stop. make[1]: Leaving directory `/var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace' make: *** [all] Error 2 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev