On 4/29/21 7:45 PM, Han Zhou wrote:
> On Thu, Apr 29, 2021 at 5:11 AM Ilya Maximets <i.maxim...@ovn.org> wrote:
>>
>> System test logs are not saved due to insufficient access rights:
>>
>>   cp: cannot open './tests/system-kmod-testsuite.dir/001/ovs-vswitchd.log'
>>         for reading: Permission denied
>>   cp: cannot open './tests/system-kmod-testsuite.dir/001/conf.db'
>>         for reading: Permission denied
>>   cp: cannot open './tests/system-kmod-testsuite.dir/001/ovsdb-server.log'
>>         for reading: Permission denied
>>
>> Adding read permissions to all users before copying to avoid that.
>>
>> Fixes: e45e94b00503 ("ci: Enable OVN system tests in GitHub Actions
> runs.")
>> Signed-off-by: Ilya Maximets <i.maxim...@ovn.org>
>> ---
>>
>> Bad build from current master branch:
>>
> https://github.com/ovn-org/ovn/runs/2462470784?check_suite_focus=true#step:13:27
>>
>> Build with this patch applied:
>>
> https://github.com/igsilya/ovn/runs/2466053019?check_suite_focus=true#step:13:31
>>
>>  .github/workflows/test.yml | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
>> index b963e2244..4a150a312 100644
>> --- a/.github/workflows/test.yml
>> +++ b/.github/workflows/test.yml
>> @@ -113,6 +113,8 @@ jobs:
>>          mkdir logs
>>          cp config.log ./logs/
>>          cp -r ./*/_build/sub/tests/testsuite.* ./logs/ || true
>> +        # System tests are run as root, need to adjust permissions.
>> +        sudo chmod -R +r ./tests/system-kmod-testsuite.* || true
>>          cp -r ./tests/system-kmod-testsuite.* ./logs/ || true
>>          tar -czvf logs.tgz logs/
>>
> 
> Thanks Ilya.
> Acked-by: Han Zhou <hz...@ovn.org>

Same here, thanks, Han and Ilya!

Acked-by: Dumitru Ceara <dce...@redhat.com>

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to