> -----Original Message----- > From: Stokes, Ian <ian.sto...@intel.com> > Sent: Tuesday, June 29, 2021 5:40 PM > To: Amber, Kumar <kumar.am...@intel.com>; d...@openvswitch.org > Cc: i.maxim...@ovn.org; Ferriter, Cian <cian.ferri...@intel.com>; Van Haaren, > Harry <harry.van.haa...@intel.com> > Subject: RE: [ovs-dev] [v4 12/12] dpif/dpcls: limit count subtable search > info logs > > > From: Harry van Haaren <harry.van.haa...@intel.com> > > > > This commit avoids many instances of "using subtable X for miniflow (x,y)" > > in the ovs-vswitchd log when using the DPCLS Autovalidator. This occurs > > when no specialized subtable is found, and the generic "_any" version of > > the avx512 subtable search implementation was used. This change logs the > > subtable usage once, avoiding duplicates. > > > > Good point here, I think people forget there is a cost to logs and no need to > flood > them. > > Just to confirm, I think this log is already upstream? What I mean is that it > is not > added by either the DPIF or MFEX patch series so this is the earliest we can > make the > change on it?
This change can be made earlier. The logs spam gets worse if we use the autovalidator, so it was identified as an issue to fix when testing with MFEX autovalidator && DPCLS autovalidator, hence why here in the patchset. Can submit separately if preferred. > Regards > Ian Thanks for review, -Harry <snip patch contents> _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
