On 28/05/2021 20:50, Flavio Leitner wrote: > On Fri, Apr 30, 2021 at 11:31:27AM -0400, Mark Gray wrote: >> 'n_handlers' and 'n_revalidators' are declared as type 'size_t'. >> However, dpif_handlers_set() requires parameter 'n_handlers' as >> type 'uint32_t'. This patch fixes this type mismatch. > The change looks good, but I didn't understand the criteria used > to do the change. For example, at udpif_stop_threads() you changed > from 'size_t' to 'uint32_t', but variable 'i' is not required > to be of the same type (marked in line below). However, I could > find other similar cases left unchanged. > > fbl >
Yes. The changes that you highlighted seem a bit arbitrary. I removed them and just left the updates to the various function signatures and variable declarations. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
