> From: Kumar Amber <kumar.am...@intel.com> > > This commit introduces additional command line paramter > for mfex study function. If user provides additional packet out > it is used in study to compare minimum packets which must be processed > else a default value is choosen. > Also introduces a third paramter for choosing a particular pmd core. > > $ ovs-appctl dpif-netdev/miniflow-parser-set study 500 3 > > Signed-off-by: Kumar Amber <kumar.am...@intel.com> >
Hi Amber, one minor comment below <snipped patch contents> > + /* If name is study and more args exist, parse study_count value. */ > + } else if (mfex_name && mfex_name_is_study) { > + if (!str_to_uint(argv[1], 10, &study_count) || > + (study_count == 0)) { > + ds_put_format(&reply, Minor, lower case for invalid below, can be fixed upon commit. Thanks Ian > + "Error: Invalid study_pkt_cnt value: %s.\n", argv[1]); > + goto error; > + } _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev