On 15/07/2021 18:31, Aaron Conole wrote:
> Mark Gray <mark.d.g...@redhat.com> writes:
> 
>> 'n_handlers' and 'n_revalidators' are declared as type 'size_t'.
>> However, dpif_handlers_set() requires parameter 'n_handlers' as
>> type 'uint32_t'. This patch fixes this type mismatch.
>>
>> Signed-off-by: Mark Gray <mark.d.g...@redhat.com>
>> Acked-by: Flavio Leitner <f...@sysclose.org>
>> ---
>>
>> Notes:
>>     v1 - Reworked based on Flavio's comments:
>>          * fixed inconsistency with change of size_t -> uint32_t
>>
>>  ofproto/ofproto-dpif-upcall.c | 20 ++++++++++----------
>>  ofproto/ofproto-dpif-upcall.h |  5 +++--
>>  ofproto/ofproto-provider.h    |  2 +-
>>  ofproto/ofproto.c             |  2 +-
>>  4 files changed, 15 insertions(+), 14 deletions(-)
>>
> 
> I guess this is more of a cleanup - did it fix anything in practice?
> 
> Either way,
> 
> Acked-by: Aaron Conole <acon...@redhat.com>
> 

It was required as I needed to modify some of the DPIF interfaces in a
later patch and this change was a per-requisite.

Thanks for the review Aaron.

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to