On 16/07/2021 16:44, Stokes, Ian wrote: >>> The first two patches do not provide new functionality for the user >>> (except the logs are reworked). They are reworking to make the >>> rxq scheduling and PMD auto load balance code more modular for cleanup >>> and to be used by subsequent patches. They are also removing the code >>> duplication between them by having some common functions they can both >> use. >>> >>> The other patches are new functionality and unit tests. >>> >>> github actions passing: >>> https://github.com/kevintraynor/ovs/actions/runs/1011364932 >> >> Hi Kevin, series LGTM, but on validation I saw a failure for appveyor >> >> https://ci.appveyor.com/project/istokes/ovs- >> ylska/builds/40021277/job/yd4h1he2p5r8m8l0 >> >> It's no clear whats causing it, it seems to have successful build but exits >> with >> code 2. >> >> I'm trying to run a session on master with appveyor at the moment to see if >> the >> issue is related to the series. >> >> Any thoughts? >> > > Actually just found the culprit. > > c:\PTHREADS-BUILT\include\_ptw32.h(120): note: see previous definition of > 'HAVE_STRUCT_TIMESPEC' > lib/dpif-netdev.c(231): error C2365: 'SCHED_MAX': redefinition; previous > definition was 'enumerator' > c:\PTHREADS-BUILT\include\sched.h(119): note: see declaration of 'SCHED_MAX' > Debug.c > Driver.c > lib/dpif-netdev.c(232): error C2086: 'sched_assignment_type SCHED_MAX': > redefinition > lib/dpif-netdev.c(231): note: see declaration of 'SCHED_MAX' > lib/dpif-netdev.c(3191): warning C4311: 'type cast': pointer truncation from > 'const char *const ' to 'long' Event.c > lib/dpif-netdev.c(5191): error C2196: case value '2' already used > > Seems it doesn't like the use of SCHED_MAX. >
Yes, seems to be in windows too :/ I'm not using it anyway, so I can just remove. Will re-spin. thanks, Kevin. > Regards > Ian >> Regards >> Ian >> _______________________________________________ >> dev mailing list >> d...@openvswitch.org >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
