On Mon, Jul 26, 2021 at 7:39 PM Numan Siddique <num...@ovn.org> wrote: > > On Mon, Jul 26, 2021 at 10:04 PM Han Zhou <zhou...@gmail.com> wrote: > > > > On Mon, Jul 26, 2021 at 6:47 PM Han Zhou <zhou...@gmail.com> wrote: > > > > > > > > > > > > On Fri, Jul 16, 2021 at 4:45 AM <num...@ovn.org> wrote: > > > > > > > > From: Numan Siddique <num...@ovn.org> > > > > > > > > This would uncomplicate the binding.c code a bit. The tracking > > > > data and the related functions are also moved to the file - ldata.h. > > > > This would help in an upcoming patch. > > > > > > > > Hi Numan, > > > > Sorry that one more comment regarding the new module "ldata" naming. It is > > a little confusing to me. Maybe it is supposed to take care of local > > bindings? Would local_binding be better? "l" can mean logical, local or > > something else. > > Hi Han, > > I supposed to mean "local data". I thought naming "local_binding.c" > or "lbinding.c" would > be confusing since we already have binding.c > > My idea was for this file to be used for maintaining local data and > not just binding. > > Does "local_data.c" seem fine to you ? > To my understanding local data includes local port-bindings and local datapath-bindings, which is local data of the original binding.c module, so I thought local_binding.c should be clear. I am also fine with local_data.c.
Thanks, Han > > Regarding your comment on "has_local_l3gateway" in the previous reply, > you're right. > I'll handle that in v2. > > Thanks for the reviews. > > Numan > > > > > > Thanks, > > Han > > _______________________________________________ > > dev mailing list > > d...@openvswitch.org > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev