On 8/11/21 5:43 PM, Paolo Valerio wrote:
> in case nl_msg_nlmsgerr returns true which basically means that the
> nlmsg_type == NLMSG_ERROR, we need to log the error code, besides the
> descriptive representation, stored by nl_msg_nlmsgerr instead of
> "error".
>
> Fixes: 72d32ac0b3a1 ("netlink-socket: Make caller provide message receive
> buffers.")
> Suggested-by: Marcelo Ricardo Leitner <mleit...@redhat.com>
> Signed-off-by: Paolo Valerio <pvale...@redhat.com>
> ---
> lib/netlink-socket.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c
> index 534bb5061..5867de564 100644
> --- a/lib/netlink-socket.c
> +++ b/lib/netlink-socket.c
> @@ -917,7 +917,7 @@ nl_sock_transact_multiple__(struct nl_sock *sock,
> }
> if (txn->error) {
> VLOG_DBG_RL(&rl, "received NAK error=%d (%s)",
> - error, ovs_strerror(txn->error));
> + txn->error, ovs_strerror(txn->error));
> }
> } else {
> txn->error = 0;
>
Thanks! Applied this one patch to master and backported down to 2.12.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
