On Fri, Sep 17, 2021 at 1:31 PM Numan Siddique <num...@ovn.org> wrote: > > On Thu, Sep 16, 2021 at 11:05 PM Zhen Wang via dev > <ovs-dev@openvswitch.org> wrote: > > > > From: zhen wang <zhew...@nvidia.com> > > > > This reverts commit 1e59feea933610b28fd4442243162ce35595cfee. > > Above commit introduced a bug when muptiple ovn-northd instances work in HA > > mode. If SB leader and active ovn-northd instance got killed by system power > > outage, standby ovn-northd instance would never detect the failure. > > > > Signed-off-by: zhen wang <zhew...@nvidia.com> > > I'm not sure if we can revert this commit. How would you propose to fix the > issue mentioned in the commit message of the commit 1e59feea933610 ? > > I think you should configure a desired probe interval value in NB_Global.options > so that the stand-by northd instance can detect the failure. With > this configuration and > with your patch 2, the issue reported by you should be addressed. > > Another option is to reset the probe interval from 0 to the default > value - DEFAULT_PROBE_INTERVAL_MSEC > once northd has successfully connected to the Northbound db server if > CMS has not configured the probe > interval in NB_Global.options. > > Thanks > Numan >
Hi Numan, sorry that I cross replied. Please see my other reply for the points you mentioned. -Han > > > > --- > > northd/northd.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/northd/northd.c b/northd/northd.c > > index 688a6e4ef..b7e64470f 100644 > > --- a/northd/northd.c > > +++ b/northd/northd.c > > @@ -74,8 +74,8 @@ static bool use_ct_inv_match = true; > > > > /* Default probe interval for NB and SB DB connections. */ > > #define DEFAULT_PROBE_INTERVAL_MSEC 5000 > > -static int northd_probe_interval_nb = 0; > > -static int northd_probe_interval_sb = 0; > > +static int northd_probe_interval_nb = DEFAULT_PROBE_INTERVAL_MSEC; > > +static int northd_probe_interval_sb = DEFAULT_PROBE_INTERVAL_MSEC; > > #define MAX_OVN_TAGS 4096 > > > > /* Pipeline stages. */ > > -- > > 2.20.1 > > > > _______________________________________________ > > dev mailing list > > d...@openvswitch.org > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > > _______________________________________________ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
