On 9/2/21 17:53, Dumitru Ceara wrote: > On 9/2/21 5:34 PM, Terry Wilson wrote: >> This ports the C IDL change f50714b to the Python IDL: >> >> Until now the code here would happily try to send transactions to the >> database server even if the database connection was not in the correct >> state. In some cases this could lead to strange behavior, such as sending >> a database transaction for a database that the IDL had just learned did not >> exist on the server. >> >> Signed-off-by: Terry Wilson <twil...@redhat.com> >> --- >> python/ovs/db/idl.py | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/python/ovs/db/idl.py b/python/ovs/db/idl.py >> index ecae5e143..87ee06cde 100644 >> --- a/python/ovs/db/idl.py >> +++ b/python/ovs/db/idl.py >> @@ -1505,6 +1505,11 @@ class Transaction(object): >> if self != self.idl.txn: >> return self._status >> > > Sorry, I should've probably mentioned this in the previous review, but I > missed it. > > Nit: the comment from f50714bf9a72 ("ovsdb-idl: Avoid sending > transactions when the DB is not synced up.") would be nice to have here too: > > # If we're still connecting or re-connecting, don't bother sending a > # transaction. > > I guess this can be fixed up at apply time so: > > Acked-by: Dumitru Ceara <dce...@redhat.com>
Thanks! Applied and backported down to 2.15. Further backports will require code changes, so, please, send the backported patches if they are needed. Dumitru, sorry, I messed up and didn't include the suggested comment. Feel free to submit a separate patch for that if you think it's needed. Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev