Bleep bloop. Greetings Peng He, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Peng He <xnhp0...@gmail.com> needs to sign off.
WARNING: Line is 85 characters long (recommended limit is 79)
#74 FILE: lib/conntrack.c:1447:
struct ipf_ctx *ipf_ctx = dp_packet_batch_is_empty(pkt_batch) ? NULL :
&_ipf_ctx;
WARNING: Line is 80 characters long (recommended limit is 79)
#86 FILE: lib/conntrack.c:1474:
return ipf_postprocess_conntrack(ct->ipf, pkt_batch, ipf_ctx, now, dl_type);
WARNING: Line is 80 characters long (recommended limit is 79)
#106 FILE: lib/conntrack.h:92:
ovs_be16 dl_type, bool force, bool commit, uint16_t zone,
WARNING: Line is 89 characters long (recommended limit is 79)
#136 FILE: lib/dpif-netdev.c:8289:
more_pkts = conntrack_execute(dp->conntrack, packets_,
aux->flow->dl_type, force,
WARNING: Line is 89 characters long (recommended limit is 79)
#137 FILE: lib/dpif-netdev.c:8290:
commit, zone, setmark, setlabel,
aux->flow->tp_src,
WARNING: Line is 85 characters long (recommended limit is 79)
#138 FILE: lib/dpif-netdev.c:8291:
aux->flow->tp_dst, helper,
nat_action_info_ref,
ERROR: Improper whitespace around control block
#157 FILE: lib/dpif-netdev.c:8336:
NL_ATTR_FOR_EACH_UNSAFE(a, left, actions, actions_len) {
WARNING: Line is 80 characters long (recommended limit is 79)
#183 FILE: lib/dpif-netdev.c:8361:
aux.redo_actions);
WARNING: Line is 93 characters long (recommended limit is 79)
#270 FILE: lib/ipf.c:1260:
struct ipf_ctx *ctx, long long now, ovs_be16 dl_type,
uint16_t zone,
WARNING: Line is 98 characters long (recommended limit is 79)
#321 FILE: lib/ipf.h:52:
struct ipf_ctx *ctx, long long now, ovs_be16
dl_type, uint16_t zone,
WARNING: Line is 85 characters long (recommended limit is 79)
#327 FILE: lib/ipf.h:56:
struct ipf_ctx *ctx, long long now, ovs_be16
dl_type);
Lines checked: 377, Warnings: 10, Errors: 2
Please check this out. If you feel there has been an error, please email
acon...@redhat.com
Thanks,
0-day Robot
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
