On Thu, Nov 18, 2021 at 9:17 AM Dumitru Ceara <dce...@redhat.com> wrote: > > On 11/9/21 10:08 PM, Numan Siddique wrote: > >>>> +Numan > >>>> > >>>> In general, I'm not completely sure about why sodepends.py needs to be > >>>> part of OVN and why we can't use the OVS version? > >>> OVS does not have this problem as everything is under the root tree so I > >>> assumed it would be preferred to implement it in OVN rather than add > >>> stuff to OVS that will not be used by OVS. > >>> But I don't have a strong opinion on this. If you prefer to implement > >>> this in OVS and use it from OVN, I'll remove this patch from the series, > >>> send it to OVS and send a patch to OVN that uses it. > >>> > >> +Mark > >> > >> In any case, this doesn't really block the rest of the series, I think > >> patches 2-5 can be applied already to main branch if maintainers agree. > > Thanks Adrian for this patch series and Dumitru for the reviews. > > > > I applied the patches 2-5 to the main branch. > > > > For this patch > > Acked-by: Numan Siddique <num...@ovn.org> > > > > My 2 cents - I'm fine modifying the sodepends.py in OVN. I'd personally > > prefer > > to move the OVS bits into OVN for man page generation so that we can change > > the code (in future) if required as per OVN's requirements. > > > > OK, makes sense to me then. > > Acked-by: Dumitru Ceara <dce...@redhat.com>
Thanks. Applied. Numan > > Regards, > Dumitru > > _______________________________________________ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev