On Fri, Dec 3, 2021 at 9:29 AM Ilya Maximets <i.maxim...@ovn.org> wrote: > > On 11/12/21 18:49, Mike Pattrick wrote: > > Currently ingress policing uses the basic classifier to apply traffic > > control filters if hardware offload is not enabled, else it uses > > matchall. This change enables fallback onto the matchall classifier for > > cases when the kernel is not built with basic support and hardware > > offload is not in use. Basic is still selected first. > > Hello, Mike. I'm not sure I understand the reason behind the logic here. > > If 'matchall' is better (as you stated in previous versions of a patch), > why not try it first and fall back to 'basic' if not available?
I think I was going for maintaining the current behaviour as much as possible. The matchall classifier is technically more efficient than basic, but I wasn't able to find a noticeable difference in my testing. If you prefer, I can flip that logic? Cheers, Michael > Best regards, Ilya Maximets. > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
