-----Original Message-----
From: Ilya Maximets <i.maxim...@ovn.org> 
Sent: Monday 29 November 2021 18:00
To: Nir Anteby <nant...@nvidia.com>; d...@openvswitch.org; Stokes, Ian 
<ian.sto...@intel.com>; Finn, Emma <emma.f...@intel.com>
Cc: el...@nvidia.com; i.maxim...@ovn.org; Maxime Coquelin 
<maxime.coque...@redhat.com>; Sriharsha Basavapatna 
<sriharsha.basavapa...@broadcom.com>
Subject: Re: [ovs-dev] [PATCH v4 0/4] netdev datapath hardware offload support 
for GRE flows

On 10/21/21 11:18, Nir Anteby via dev wrote:
> V1: 
> Add hardware offload support for GRE flows (experimental).
> Available only if DPDK experimantal APIs enabled during the build.
>   
> V2:
> Rebase version
>   
> v3:
> Fixed rebase compilation
> 
> v4:
> *Rebase version
> *Fixed bug found by maxime.coque...@redhat.com, vport is always null 
> *The feature will work only after applying the following patches in dpdk:
>  http://mails.dpdk.org/archives/dev/2021-September/219590.html
>  and
>  http://mails.dpdk.org/archives/dev/2021-September/219591.html
>  Those patches got marged to the next-version of dpdk on 19 Oct 2021.
>  
> *CI result : https://github.com/nanteby/ovs/actions/runs/1362805166
> 
> Nir Anteby (4):
>   netdev-offload-dpdk: Refactor get_vport_netdev()
>   netdev-dpdk: Add flow_api support for netdev gre vports
>   netdev-offload-dpdk: Support tnl_pop for gre tunnel
>   netdev-offload-dpdk: Add support for matching on gre fields
> 
>  NEWS                      |   2 +
>  lib/netdev-dpdk.c         |   7 ++-
>  lib/netdev-offload-dpdk.c | 144 
> +++++++++++++++++++++++++++++++++++++++-------
>  3 files changed, 130 insertions(+), 23 deletions(-)
> 

Hi, Nir.  Patches seems OK in general, though I didn't look very close.
It would be great to have them tested by other vendors.

Ian, Emma, may I ask you to verify that this change doesn't break offloading 
with Intel NICs?

Best regards, Ilya Maximets.


Tested this series on Intel NICs and doesn't break any existing offload support.
Intel NICs do not support offloading of GRE flows. 

Tested-by: Emma Finn <emma.f...@intel.com>

Thanks, 
Emma 

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to