After commit [0] the mandatory vtep chassis's option 'is-vtep' has appeared.
The upgrade scenario for ovn-controller-vtep was not supported:
'is-vtep' option was set only on vtep chassis creation. If chassis was
created prior to a new codebase, it was left intact and HW VTEP connectivity
was broken.
This commit fixes such scenario and now 'is-vtep' is set for vtep chassis
other_config if was not set yet.

0: 
https://github.com/ovn-org/ovn/commit/1c360bbd911cab9fadd6df8cd528d992ffa7a998

Fixes: 1c360bbd911cab9fadd6df8cd528d992ffa7a998 (Fix basic multicast flows for 
vxlan (non-vtep) tunnels)
Signed-off-by: Vladislav Odintsov <odiv...@gmail.com>
---
After this patch is accepted to main branch, it should be considered to be
backported to branch-21.12, as the problem is shown originally in that version.
---
 controller-vtep/gateway.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/controller-vtep/gateway.c b/controller-vtep/gateway.c
index 288772dc4..9fbfc0337 100644
--- a/controller-vtep/gateway.c
+++ b/controller-vtep/gateway.c
@@ -22,6 +22,7 @@
 #include "lib/util.h"
 #include "openvswitch/vlog.h"
 #include "lib/ovn-sb-idl.h"
+#include "smap.h"
 #include "vtep/vtep-idl.h"
 #include "ovn-controller-vtep.h"
 
@@ -117,6 +118,10 @@ revalidate_gateway(struct controller_vtep_ctx *ctx)
                                                                   "false");
                 sbrec_encap_set_options(chassis_rec->encaps[0], &options);
             }
+            if (!smap_get_bool(&chassis_rec->other_config, "is-vtep", false)) {
+                const struct smap oc = SMAP_CONST1(&oc, "is-vtep", "true");
+                sbrec_chassis_set_other_config(chassis_rec, &oc);
+            }
         } else {
             if (gw_node) {
                 VLOG_WARN("Chassis for VTEP physical switch (%s) disappears, "
-- 
2.30.0

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to