On Wed, Jan 26, 2022 at 06:39:52PM -0800, William Tu wrote: > On Wed, Jan 26, 2022 at 8:56 AM Ben Pfaff <b...@ovn.org> wrote: > > > > Until now, the monitor process held its log file open while it waited for > > the child to exit, and then it reopened it after the child exited. Holding > > the log file open this way prevented log rotation from freeing disk space. > > This commit avoids the problem by closing the log file before waiting, then > > reopening it afterward. > > > > Signed-off-by: Ben Pfaff <b...@ovn.org> > > Reported-by: Antonin Bas <a...@vmware.com> > > VMware-BZ: #2743409 > > --- > > Hi Ben, > Thanks, ASAN reports a memory leak,
[...] > I think we should "free(log_file)" after vlog_set_log_file(log_file)? You are right. Thank you for the report. I posted v2: https://mail.openvswitch.org/pipermail/ovs-dev/2022-January/391119.html _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
