On 1/10/22 09:13, Eelco Chaudron wrote: > Currently, if a flow reply results in a message which exceeds > the maximum reply size, it will assert OVS. This would happen > when OVN uses OpenFlow15 to add large flows, and they get read > using OpenFlow10 with ovs-ofctl. > > This patch prevents this and adds a test case to make sure the > code behaves as expected. > > Signed-off-by: Eelco Chaudron <[email protected]> > Reviewed-by: Maxime Coquelin <[email protected]> > --- > v4: > - Use only printf in unit test, instead of mixed echo and printf > - Use ofpbuf_headersize() > v3: > - Remove ofpbuf_oversized(), as we need to know if our message > is larger than 64k (minus common header), i.e., not including > the already existing ones. > v2: > - Fixed test to actually verify the output. > - Used ofpbuf_oversized() instead of manual calculation. > > lib/ofp-flow.c | 11 ++++++++++- > tests/ovs-ofctl.at | 19 +++++++++++++++++++ > 2 files changed, 29 insertions(+), 1 deletion(-)
Thanks! Applied and backported down to 2.13. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
