> On 08/02/2022 12:52, Stokes, Ian wrote: > >> On Thu, Jan 13, 2022 at 5:24 PM Kevin Traynor <[email protected]> > wrote: > >>> > >>> This patch updates OVS to use DPDK RTE_ETH namespaces. > >>> > >>> DPDK commit 295968d17407 ("ethdev: add namespace") [0] added RTE_ETH > >>> namespaces for ethdev enums and macros in DPDK 21.11. > >>> > >>> As compatibility for the older names was kept and they were not officially > >>> deprecated in DPDK 21.11, there was no impact to OVS and OVS did not > have > >>> to be updated. > >>> > >>> In future DPDK releases the older names will be deprecated and that will > >>> cause build warnings for OVS. They may also be removed from DPDK at > some > >>> point. > >>> > >>> There is no immediate need to update OVS to use the new namespaces > while > >>> DPDK 21.11 is being used but at the same time there is no need to wait > >>> until it becomes an issue either. So might as well align with the > >>> updated names in DPDK 21.11. > > > > Thanks Kevin, LGTM so applied and pushed to master. > > > > Cool, thanks. > > > Do you think this should be applied to 2.17 also? As it uses 21.11. > > > > I'm just wondering will it make back porting any fixes on master to 2.17 > > easier > in the future also. > > > > Thoughts? > > > > Even though it's a straightforward, cautious me says it's a change that > is not needed on 2.17 and it's very close to the release date, so let's > not backport it now. We could always backport at a later time mid 2.17.x > release cycle if turns out to cause conflicts for other backports. >
Sure, I think that’s a fair call, let's leave it out of 2.17 at this point. This patch was needed for dpdk-latest branch as well for compilation to succeed with DPDK shared libraries enabled, so have rebased dpdk-latest and pushed that update as well. Thanks Ian > thanks, > Kevin. > > > Thanks > > Ian > > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
