On 2/11/22 19:31, Numan Siddique wrote:
> On Fri, Feb 11, 2022 at 9:42 AM Dumitru Ceara <dce...@redhat.com> wrote:
>> It's useful to differentiate between ingress and egress pipelines in the
>> ACL logs.  To achieve this we determine the direction by interpreting the
>> openflow table ID when processing packets punted to pinctrl by "log()"
>> action.
>>
>> Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1992641
>> Signed-off-by: Dumitru Ceara <dce...@redhat.com>
>> ---
>> v3: Simplify the patch as suggested by Numan; detect pipeline based on
>> openflow table id.
>> v2: Add the "direction" after the "verdict" and "severity" fields in the
>> ACL logs.
>> ---
> Thanks for v3.
> 
> I've one minor comment.  I somehow feel using "from-lport" and
> "to-lport" instead of "IN" and "OUT"
> would be more appropriate.  But I'm fine with the present patch too.
> 
> Acked-by: Numan Siddique <num...@ovn.org>
> 

Thanks, I sent a v4 including your ack and the suggested change.

Regards,
Dumitru

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to